Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use unittest.mock instead of mock #668

Merged
merged 3 commits into from Jun 17, 2022
Merged

Conversation

reoono
Copy link
Contributor

@reoono reoono commented Jun 16, 2022

What does this PR do?

Changed to use unittest.mock instead of mock.

  • Supported versions of Python have unittest as a standard library,
  • Unnecessary dependencies can be removed.

Fixes #659

@codecov
Copy link

codecov bot commented Jun 16, 2022

Codecov Report

Merging #668 (59bb483) into main (43b6712) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #668   +/-   ##
=======================================
  Coverage   91.64%   91.64%           
=======================================
  Files          17       17           
  Lines        1568     1568           
=======================================
  Hits         1437     1437           
  Misses        131      131           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43b6712...59bb483. Read the comment docs.

Copy link
Member

@MSeal MSeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This was a left-over from supporting older Python versions

@MSeal MSeal merged commit a6b00a8 into nteract:main Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

use unittest.mock instead of mock
2 participants