Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(iorw.py): update HDFSHandler to adapt PyArrow.fs.HadoopFileSystem API #658

Merged
merged 4 commits into from May 1, 2022

Conversation

reoono
Copy link
Contributor

@reoono reoono commented Mar 25, 2022

What does this PR do?

Fixes #657

I fix HDFSHandler to match PyArrow.fs.HadoopFileSystem API.

As stated the reasons in #657, I removed import PyArrow.HadoopFileSystm and updated requirements/hdfs.txt.

Copy link
Member

@MSeal MSeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix. I'm ok with dropping support for older pyarrow versions (I'll add that fact to the changelog for the next release). Sorry I was out sick for a bit and wasn't tracking the project actively for a little bit

@MSeal MSeal merged commit 76906a8 into nteract:main May 1, 2022
@reoono reoono mentioned this pull request May 18, 2022
@reoono
Copy link
Contributor Author

reoono commented May 18, 2022

My apologies for the delay in replying as well.
Thank you very much for your response despite the difficult situation.

This PR has caused flake8 to fail and I would like to fix it.
(If possible, I would also like to fix Python 3.8~3.10 failing.)

@reoono reoono deleted the fix-hadoop-filesystem branch May 18, 2022 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError: pyarrow._hdfs.HadoopFileSystem__init__() takes at least 1 positional argument (0 given)
2 participants