Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support new version of gcsfs #624

Merged
merged 6 commits into from Aug 31, 2021
Merged

Support new version of gcsfs #624

merged 6 commits into from Aug 31, 2021

Conversation

onevirus
Copy link
Contributor

@onevirus onevirus commented Aug 2, 2021

What does this PR do?

  • Import retry module from gcsfs package

@MSeal
I tested only latest version of gcsfs. IMHO, it's hard and will be harder to support old gcsfs.
So, how about update minimum version of gcsfs to 'gcsfs>=2021.07.0' and remove old import statements ?

Fixes #623

@codecov
Copy link

codecov bot commented Aug 2, 2021

Codecov Report

Merging #624 (9522f30) into main (d30bcf2) will decrease coverage by 1.04%.
The diff coverage is 46.15%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #624      +/-   ##
==========================================
- Coverage   92.68%   91.63%   -1.05%     
==========================================
  Files          17       17              
  Lines        1518     1555      +37     
==========================================
+ Hits         1407     1425      +18     
- Misses        111      130      +19     
Impacted Files Coverage Δ
papermill/iorw.py 79.01% <46.15%> (-4.62%) ⬇️
papermill/exceptions.py 86.66% <0.00%> (+6.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5b787e...9522f30. Read the comment docs.

Copy link
Member

@MSeal MSeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TY! I really appreciate this fix for the builds.

@MSeal MSeal merged commit 3f6225e into nteract:main Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need fix for recent GCFS changes
2 participants