Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(angular): use @nrwl/web:file-server in serve-static targets #16009

Merged

Conversation

leosvelperez
Copy link
Member

@leosvelperez leosvelperez commented Mar 31, 2023

Current Behavior

The application generator creates the serve-static target with the non-existent @nrwl/angular:file-server executor.

Expected Behavior

The application generator should create the serve-static target with the @nrwl/web:file-server executor.

Related Issue(s)

Fixes #16005

@leosvelperez leosvelperez self-assigned this Mar 31, 2023
@vercel
Copy link

vercel bot commented Mar 31, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated
nx-dev ⬜️ Ignored (Inspect) Mar 31, 2023 at 2:14PM (UTC)

@leosvelperez leosvelperez marked this pull request as ready for review March 31, 2023 14:15
@FrozenPandaz FrozenPandaz merged commit ad37d77 into nrwl:master Mar 31, 2023
3 checks passed
@leosvelperez leosvelperez deleted the angular/fix-serve-static-executor branch March 31, 2023 15:16
@github-actions
Copy link

github-actions bot commented Apr 6, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New generated standalone application still uses @nrwl/angular:file-server
2 participants