Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react): add missing dependencies #15976

Merged
merged 1 commit into from
Mar 30, 2023

Conversation

jaysoo
Copy link
Member

@jaysoo jaysoo commented Mar 30, 2023

A couple of dependencies ('file-loader and @svgr/webpack) are used by the withReact webpack plugin, but they are missing in @nrwl/react/package.json so they might not be resolved if not hoisted to root node_modules. This PR adds those missing dependencies.

@vercel
Copy link

vercel bot commented Mar 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated
nx-dev ⬜️ Ignored (Inspect) Mar 30, 2023 at 0:21AM (UTC)

@ndcunningham ndcunningham merged commit 9f395e8 into nrwl:master Mar 30, 2023
@jaysoo jaysoo deleted the fix/react-missing-deps branch March 30, 2023 15:50
@github-actions
Copy link

github-actions bot commented Apr 5, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants