fix(core): fix invalid yarn parser dependencies grouping key #15647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Closes: #15603 |
meeroslav
commented
Mar 13, 2023
| @@ -227,7 +227,7 @@ function groupDependencies( | |||
| const resolutionMap = new Map<string, YarnDependency>(); | |||
| const snapshotMap = new Map<YarnDependency, Set<string>>(); | |||
| Object.entries(dependencies).forEach(([key, snapshot]) => { | |||
| const resolutionKey = `${snapshot.resolution}${snapshot.integrity}`; | |||
There was a problem hiding this comment.
This was a typo - grouping is only created for Yarn Classic, which has resolved, not for Yarn Berry which has a resolution field
FrozenPandaz
approved these changes
Mar 14, 2023
FrozenPandaz
pushed a commit
that referenced
this pull request
Mar 15, 2023
(cherry picked from commit 3f4ba6d)
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The yarn parser uses an invalid key for grouping dependencies causing different snapshots to be grouped together.
Reported by @yharaskrik on Slack: https://nrwlcommunity.slack.com/archives/CMFKWPU6Q/p1677717333068159
Current Behavior
Expected Behavior
Related Issue(s)
Related to #15364
Fixes #15603