fix(angular): prevent updating unchanged projects when syncing changes to the wrapped tree #15503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…s to the wrapped tree
leosvelperez
force-pushed
the
angular/ngcli-adapter-unchanged-project-config
branch
from
0bbb3b6
to
2b94e0e
Compare
AgentEnder
approved these changes
Mar 8, 2023
nartc
pushed a commit
to nartc/nx
that referenced
this pull request
Mar 9, 2023
…s to the wrapped tree (nrwl#15503)
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
When syncing changes back to the wrapped tree for schematics, the adapter updates all existing projects regardless of whether they are modified.
This surfaces an issue in workspaces with at least one project in a
package.json. Because we update all projects, it throws when trying to update thepackage.jsonbased project because our utility doesn't support updating those projects. If it throws before the project that needs to be updated or created, it results in the project not getting the changes or not being created.Expected Behavior
The adapter should only update existing modified projects when syncing changes to the wrapped tree for schematics.
Related Issue(s)
Fixes #15348