feat(angular): move replaceAppNameWithPath to Angular #15493
Merged
+71
−80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coly010
requested review from
FrozenPandaz,
AgentEnder,
vsavkin and
leosvelperez
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
leosvelperez
reviewed
Mar 7, 2023
There was a problem hiding this comment.
I have my doubts about making this function part of the DevKit public API. It's probably not something generic enough to make it available for everyone. The logic is Angular-specific and it's only used on the Angular plugin. I would inline it in the Angular plugin utils.
Coly010
force-pushed
the
move-replace-app-name
branch
from
545d2fd to
feeb6ce
Compare
Coly010
requested review from
jaysoo,
ndcunningham,
mandarini and
xiongemi
as code owners
Coly010
force-pushed
the
move-replace-app-name
branch
from
feeb6ce to
541f721
Compare
Coly010
requested review from
leosvelperez
and removed request for
ndcunningham,
mandarini and
xiongemi
leosvelperez
requested changes
Mar 7, 2023
packages/angular/src/generators/application/lib/update-config-files.ts
Outdated
Show resolved
Hide resolved
packages/angular/src/generators/application/angular-v14/lib/update-config-files.ts
Outdated
Show resolved
Hide resolved
mandarini
approved these changes
Mar 7, 2023
Coly010
changed the title
Coly010
changed the title
Coly010
force-pushed
the
move-replace-app-name
branch
from
541f721 to
58a5834
Compare
leosvelperez
approved these changes
Mar 7, 2023
FrozenPandaz
requested changes
Mar 7, 2023
Coly010
force-pushed
the
move-replace-app-name
branch
from
58a5834 to
78b4e1e
Compare
Coly010
force-pushed
the
move-replace-app-name
branch
from
78b4e1e to
cebdd5d
Compare
AgentEnder
approved these changes
Mar 8, 2023
FrozenPandaz
approved these changes
Mar 8, 2023
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
replaceAppNameWithPath is used in multiple plugins via a deep import to @nrwl/workspace
Expected Behavior
Move the function to Angular
Deprecate the existing fuction in @nrwl/workspace to allow plugin authors time to migrate.
Related Issue(s)
Fixes #