Skip to content

Commit f2fb4c8

Browse files
authoredMar 20, 2023
fix(angular): fix wrong tsconfig option name in webpack-dev-server implementation (#15765)
1 parent a91513d commit f2fb4c8

File tree

1 file changed

+11
-8
lines changed

1 file changed

+11
-8
lines changed
 

‎packages/angular/src/builders/webpack-dev-server/webpack-dev-server.impl.ts

+11-8
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,13 @@ import { from } from 'rxjs';
1919
import { switchMap } from 'rxjs/operators';
2020
import { getRootTsConfigPath } from 'nx/src/utils/typescript';
2121

22+
type BuildTargetOptions = {
23+
tsConfig: string;
24+
buildLibsFromSource?: boolean;
25+
customWebpackConfig?: { path?: string };
26+
indexFileTransformer?: string;
27+
};
28+
2229
export function executeWebpackDevServerBuilder(
2330
rawOptions: Schema,
2431
context: import('@angular-devkit/architect').BuilderContext
@@ -38,7 +45,7 @@ export function executeWebpackDevServerBuilder(
3845
const buildTarget =
3946
browserTargetProjectConfiguration.targets[parsedBrowserTarget.target];
4047

41-
const buildTargetOptions = {
48+
const buildTargetOptions: BuildTargetOptions = {
4249
...buildTarget.options,
4350
...(parsedBrowserTarget.configuration
4451
? buildTarget.configurations[parsedBrowserTarget.configuration]
@@ -83,13 +90,9 @@ export function executeWebpackDevServerBuilder(
8390
let dependencies: DependentBuildableProjectNode[];
8491
if (!buildLibsFromSource) {
8592
const { tsConfigPath, dependencies: foundDependencies } =
86-
createTmpTsConfigForBuildableLibs(
87-
buildTargetOptions.buildTargetTsConfigPath,
88-
context,
89-
{
90-
target: parsedBrowserTarget.target,
91-
}
92-
);
93+
createTmpTsConfigForBuildableLibs(buildTargetOptions.tsConfig, context, {
94+
target: parsedBrowserTarget.target,
95+
});
9396
dependencies = foundDependencies;
9497

9598
// We can't just pass the tsconfig path in memory to the angular builder

0 commit comments

Comments
 (0)
Please sign in to comment.