Skip to content

Commit 8010270

Browse files
nadavshatzFrozenPandaz
authored andcommittedAug 21, 2023
fix(react): fix remote generation devServerPort (#18603)
(cherry picked from commit 1a0962f)
1 parent 495d5f7 commit 8010270

File tree

3 files changed

+5
-2
lines changed

3 files changed

+5
-2
lines changed
 

‎docs/generated/packages/react/generators/remote.json

-1
Original file line numberDiff line numberDiff line change
@@ -147,7 +147,6 @@
147147
"devServerPort": {
148148
"type": "number",
149149
"description": "The port for the dev server of the remote app.",
150-
"default": 4200,
151150
"x-priority": "important"
152151
},
153152
"ssr": {

‎e2e/react-core/src/react-module-federation.test.ts

+5
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,11 @@ describe('React Module Federation', () => {
4444
combinedOutput: expect.stringContaining('Test Suites: 1 passed, 1 total'),
4545
});
4646

47+
expect(readPort(shell)).toEqual(4200);
48+
expect(readPort(remote1)).toEqual(4201);
49+
expect(readPort(remote2)).toEqual(4202);
50+
expect(readPort(remote3)).toEqual(4203);
51+
4752
updateFile(
4853
`apps/${shell}/webpack.config.js`,
4954
stripIndents`

‎packages/react/src/generators/remote/schema.json

-1
Original file line numberDiff line numberDiff line change
@@ -153,7 +153,6 @@
153153
"devServerPort": {
154154
"type": "number",
155155
"description": "The port for the dev server of the remote app.",
156-
"default": 4200,
157156
"x-priority": "important"
158157
},
159158
"ssr": {

0 commit comments

Comments
 (0)
Please sign in to comment.