fix: Add suffix to template files

[rotu]

Add .hbs as a suffix to all Handlebars template files.

This helps in:

• understanding the purpose of files in this repo (especially when searching/grepping)
• troubleshooting when something goes wrong
• prevent spurious tooling warnings, e.g. json syntax errors reported by GitHub and highlighted in red in this screenshot:
  

[wraithgar]

Look good other than the linting error now that extname isn't being used anymore.

[lukekarrys]

Can it use .hbs instead of .handlebars? I generally prefer shorter file extensions if possible. I think it makes the file sidebar easier to scan visually:

[rotu]

Can it use .hbs instead of .handlebars? I generally prefer shorter file extensions if possible.

I can do that.

BTW, when doing this PR, I realized that the existing .yml/.md/... extension is stripped off for purposes of assigning a name to the partial. I figure that's why pkg.json is named as such (instead of package.json, which would probably interfere with tooling).

Since that extension is ignored, maybe we should either:

• Must name the files e.g. _step-audit.handlebars and add a comment at the top like {{! compiled to yaml }}
• Make the destination format part of the name like _step-audit-yaml.handlebars and use {{> stepAuditYaml }}

Thoughts?

[wraithgar]

ircc think it's called pkg.json so that npm doesn't pick it up and assume that subdirectory is a package. The presence of a file named package.json is very load bearing in npm.

[wraithgar]

Thoughts?

Having the eventual extension be in the filename already is VERY helpful imo, a yaml/etc comment just isn't the same. So _step-audit-yaml.handlebars would be just keen imo.

[rotu]

ircc think it's called pkg.json so that npm doesn't pick it up and assume that subdirectory is a package. The presence of a file named package.json is very load bearing in npm.

Exactly what I meant! Calling a file package.json has unintended consequences. But calling it pkg.json, package.json.handlebars, or package-json.handlebars has no such baggage.

So _step-audit-yaml.handlebars would be just keen imo.

Sorry, I don't speak jive. I think you mean that I should go with _step-audit-yaml.handebars (or, more likely, _step-audit-yaml.hbs). Please correct if wrong!

[wraithgar]

I think _step-audit-yaml.hbs is a good choice, it keeps the yaml in the filename while removing .yaml from the "extension" chain.

ETA: It also relieves us of the pkg.json package.json disconnect problem, we can have package-json.hbs. It's a win all around.

[wraithgar]

lgtm, I'll let @lukekarrys land this one.

I really love being able to remove the local eslint config!