chore: do not sign commits in tests #311
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently running the tests creates git repos and commits using your default git configuration. for me personally, this means that i get a popup confirming the signing request for these commits since i have my git configured to always sign. this means when running tests, i get a lot of notifications. by forcibly telling git to not sign these commits, this no longer happens, and since signatures are not important for test fixtures that are being discarded anyway felt like a quick usability win here.