Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: better handling of whitespace (backport to v5) #585

Merged
merged 1 commit into from Jul 10, 2023
Merged

fix: better handling of whitespace (backport to v5) #585

merged 1 commit into from Jul 10, 2023

Conversation

joaomoreno
Copy link

This backports the security fix #564 to v5.

@joaomoreno joaomoreno requested a review from a team as a code owner July 7, 2023 13:45
@joaomoreno joaomoreno mentioned this pull request Jul 7, 2023
Merged
@wraithgar
Copy link
Member

#580 should be fixed before we go backporting anything so we don't bring new bugs along.

@wraithgar
Copy link
Member

#587 Also needs to be fixed

@lukekarrys lukekarrys force-pushed the release/v5 branch 2 times, most recently from b67c2f8 to deb5ad5 Compare July 7, 2023 17:50
@lukekarrys
Copy link
Member

the latest template-oss changes have been applied to release/v5. @joaomoreno can you rebase your branch so it only includes the semver.js and test/ changes?

@lukekarrys
Copy link
Member

The full set of changes that should be backported are:

@lukekarrys @joaomoreno
fix: better handling of whitespace
d4530b8 
This is a backport of the following commits squashed to land on
`release/v5`:

- 717534e
- abdd93d
- cc6fde2
- 99d8287

Ref: npm#564

Co-authored-by: joaomoreno <mail@joaomoreno.com>
@lukekarrys
Copy link
Member

@joaomoreno i was able to push to your branch with the relevant commits. waiting on CI to see if tests pass in older versions of node

@lukekarrys lukekarrys changed the title Backport to v5: fix: better handling of whitespace fix: better handling of whitespace (backport to v5) Jul 7, 2023
@lukekarrys lukekarrys mentioned this pull request Jul 7, 2023
Closed
1 task
@joaomoreno
Copy link
Author

Sounds good, thanks @lukekarrys!

@lukekarrys lukekarrys merged commit 2f8fd41 into npm:release/v5 Jul 10, 2023
7 checks passed
@github-actions github-actions bot mentioned this pull request Jul 10, 2023
Merged
@G-Rath
Copy link

G-Rath commented Jul 10, 2023

I've opened github/advisory-database#2483 updating the advisory for v5

@G-Rath
Copy link

G-Rath commented Jul 10, 2023

and I've opened github/advisory-database#2484 updating the advisory again for v6 and v5.

@lukekarrys
Copy link
Member

Thanks @G-Rath!

@joaomoreno
Copy link
Author

Thanks all!

@joaomoreno joaomoreno deleted the joao/backport-564-to-v5 branch July 11, 2023 09:11
@aadhar-agarwal aadhar-agarwal mentioned this pull request Aug 17, 2023
Open
@github-actions github-actions bot mentioned this pull request Dec 12, 2023
Closed
@sync-by-unito sync-by-unito bot mentioned this pull request Jan 31, 2024
Closed
@ehoogeveen-medweb ehoogeveen-medweb mentioned this pull request Feb 27, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wraithgar wraithgar wraithgar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@joaomoreno @wraithgar @lukekarrys @G-Rath