Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

diff throws w/ an unexpected error #553

Closed
macno opened this issue Apr 15, 2023 · 0 comments
Closed

diff throws w/ an unexpected error #553

macno opened this issue Apr 15, 2023 · 0 comments

Comments

@macno
Copy link
Contributor

macno commented Apr 15, 2023 

          Double checking #547 and I see a problem where it would have thrown with a good warning, now it throws w/ an unexpected error

v7.4.0

> semver.diff('foo', '1.2.3')
Uncaught TypeError: Invalid Version: null

now

> semver.diff('foo', '1.2.3')
Uncaught TypeError: Cannot read properties of null (reading 'compare')

Need to fix this before releasing

Originally posted by @wraithgar in #549 (comment)
macno added a commit to macno/node-semver that referenced this issue Apr 15, 2023
@macno
fix: check if versions are valid in diff compare (npm#553)
d99a086
macno added a commit to macno/node-semver that referenced this issue Apr 15, 2023
@macno
fix: check if versions are valid in diff compare (npm#553)
d3861a9
@macno macno closed this as completed Apr 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@macno