feat: do all ouput over proc-log events

Author: lukekarrys

lib/base-command.js

@@ -4,7 +4,7 @@ const { relative } = require('path')
 
 const { definitions } = require('@npmcli/config/lib/definitions')
 const { aliases: cmdAliases } = require('./utils/cmd-list')
-const { log } = require('proc-log')
+const { log, output } = require('proc-log')
 
 class BaseCommand {
   static workspaces = false
@@ -119,7 +119,7 @@ class BaseCommand {
     const { config } = this.npm
 
     if (config.get('usage')) {
-      return this.npm.output(this.usage)
+      return output.standard(this.usage)
     }
 
     const hasWsConfig = config.get('workspaces') || config.get('workspace').length

lib/cli-entry.js

@@ -18,7 +18,7 @@ module.exports = async (process, validateEngines) => {
   exitHandler.setNpm(npm)
 
   // only log node and npm paths in argv initially since argv can contain sensitive info. a cleaned version will be logged later
-  const { log } = require('proc-log')
+  const { log, output } = require('proc-log')
   log.verbose('cli', process.argv.slice(0, 2).join(' '))
   log.info('using', 'npm@%s', npm.version)
   log.info('using', 'node@%s', process.version)
@@ -41,7 +41,7 @@ module.exports = async (process, validateEngines) => {
 
     // npm -v
     if (npm.config.get('version', 'cli')) {
-      npm.output(npm.version)
+      output.standard(npm.version)
       return exitHandler()
     }
 
@@ -53,7 +53,7 @@ module.exports = async (process, validateEngines) => {
 
     cmd = npm.argv.shift()
     if (!cmd) {
-      npm.output(npm.usage)
+      output.standard(npm.usage)
       process.exitCode = 1
       return exitHandler()
     }
@@ -64,8 +64,8 @@ module.exports = async (process, validateEngines) => {
     if (err.code === 'EUNKNOWNCOMMAND') {
       const didYouMean = require('./utils/did-you-mean.js')
       const suggestions = await didYouMean(npm.localPrefix, cmd)
-      npm.output(`Unknown command: "${cmd}"${suggestions}\n`)
-      npm.output('To see a list of supported npm commands, run:\n  npm help')
+      output.standard(`Unknown command: "${cmd}"${suggestions}\n`)
+      output.standard('To see a list of supported npm commands, run:\n  npm help')
       process.exitCode = 1
       return exitHandler()
     }