Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a factory mechanism for the factories called by the chain builder #5561

Merged
merged 2 commits into from
Feb 9, 2024
Merged

Add a factory mechanism for the factories called by the chain builder #5561

merged 2 commits into from
Feb 9, 2024

Conversation

NinoFloris
Copy link
Member

Presented without comment.

Fixes #5562

roji
roji approved these changes Feb 7, 2024
View reviewed changes
Copy link
Member

@roji roji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice trick with the memoization for deferred initialization... Would be nice to have a comment explaining why this hoop is needed though.

@roji
Copy link
Member

roji commented Feb 7, 2024

Also test?

@NinoFloris NinoFloris merged commit d137ac6 into main Feb 9, 2024
17 checks passed
@NinoFloris NinoFloris deleted the factory-factory-builder branch February 9, 2024 18:24
NinoFloris added a commit that referenced this pull request Feb 9, 2024
@NinoFloris
Add a factory mechanism for the factories called by the chain builder (…
9e4ff8c 
…#5561)

Fixes #5562

(cherry picked from commit d137ac6)
@NinoFloris
Copy link
Member Author

Backported to 8.0.2 via 9e4ff8c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roji roji roji approved these changes

@vonzshik vonzshik Awaiting requested review from vonzshik vonzshik is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@NinoFloris @roji