Redo binary exporter column reading #5464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vonzshik
approved these changes
Nov 30, 2023
NinoFloris
force-pushed
the
fix-binary-exporter-isnull
branch
from
3e328b6
to
511e038
Compare
|
Backported to 8.0.1 via c36b1bc |
JonasWestman
pushed a commit
to monitor-erp/npgsql
that referenced
this pull request
Dec 20, 2023
Fixes npgsql#5457 (cherry picked from commit cdf9841) Signed-off-by: monjowe <jonas.westman@monitor.se>
JonasWestman
pushed a commit
to monitor-erp/npgsql
that referenced
this pull request
Dec 21, 2023
Fixes npgsql#5457 (cherry picked from commit cdf9841) Signed-off-by: monjowe <jonas.westman@monitor.se>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5457
There was a lot of code here that I don't understand after rereading it, probably left a bit too 'in-progress' after #5123 while it did pass the tests.