Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix explicit batch preparation reset #5459

Merged
merged 2 commits into from Nov 27, 2023

Conversation

vonzshik
Copy link
Contributor

Fixes #5458

Ideally we also want to at least test the same thing for autoprepare (and maybe some other cases, like adding/removing queries from batch), but that can be done separately.

@vonzshik vonzshik requested a review from roji as a code owner November 27, 2023 15:32
@vonzshik vonzshik merged commit 9e3a8df into main Nov 27, 2023
17 checks passed
@vonzshik vonzshik deleted the 5458-explicit-batch-preparation-fix branch November 27, 2023 18:28
vonzshik added a commit that referenced this pull request Nov 27, 2023
vonzshik added a commit that referenced this pull request Nov 27, 2023
vonzshik added a commit that referenced this pull request Nov 27, 2023
@vonzshik
Copy link
Contributor Author

Backported to 8.0.1 via 88f7679, 7.0.7 via f819b9f, 6.0.11 via f1d8b34.

@stojancho-jefremov
Copy link

Backported to 8.0.1 via 88f7679, 7.0.7 via f819b9f, 6.0.11 via f1d8b34.

I can see that version 8.0.1 has been out for a couple of days. Do you might know what are the plans for version 7.0.7?

JonasWestman pushed a commit to monitor-erp/npgsql that referenced this pull request Dec 20, 2023
Fixes npgsql#5458

(cherry picked from commit 9e3a8df)
Signed-off-by: monjowe <jonas.westman@monitor.se>
JonasWestman pushed a commit to monitor-erp/npgsql that referenced this pull request Dec 21, 2023
Fixes npgsql#5458

(cherry picked from commit 9e3a8df)
Signed-off-by: monjowe <jonas.westman@monitor.se>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NpgsqlBatch does not properly set ConnectorPreparedOn property on its BatchCommands
3 participants