Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] - Block Module: Temporary class name for the position #47

Closed
furcan opened this issue Jan 29, 2022 · 0 comments
Closed

[BUG] - Block Module: Temporary class name for the position #47

furcan opened this issue Jan 29, 2022 · 0 comments
Assignees
Labels
bug Something isn't working fixed Has been fixed.
Milestone

Comments

@furcan
Copy link
Collaborator

furcan commented Jan 29, 2022

Describe the bug

For the Block Module;
The temporary class name for the static positioned reference elements can not be related to the options and/or can not be dynamic. Add and remove methods have their own instances and these options always will be different from each other if using method-based init options instead of the global init.
The temporary class name should be static or a built-in state can be used to store the previous one.

Expected behaviour

The temporary class name should be removed in any case.

Additional context

This issue is also related to: #45

@furcan furcan added the bug Something isn't working label Jan 29, 2022
@furcan furcan self-assigned this Jan 29, 2022
@furcan furcan added this to Notiflix Jan 29, 2022
@furcan furcan moved this to Todo in Notiflix Jan 29, 2022
@furcan furcan added this to the v3.2.4 milestone Jan 29, 2022
furcan added a commit that referenced this issue Jan 29, 2022
Fixed: `Notiflix.Block.*`: The temporary position class name for the reference element has been changed to a constant text. [#47](#47)
@furcan furcan closed this as completed Jan 29, 2022
Repository owner moved this from Todo to Done in Notiflix Jan 29, 2022
@furcan furcan added the fixed Has been fixed. label Jan 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fixed Has been fixed.
Projects
Status: Done
Development

No branches or pull requests

1 participant