Skip to content

Commit fbafe8d

Browse files
addaleaxrvagg
authored andcommittedFeb 28, 2019
test: fix test-repl-envvars
In 180f865, the test was changed so that the `env` argument of `createInternalRepl()` also contained external environment variables, because keeping them can be necessary for spawning processes on some systems. However, this test does not spawn new processes, and relies on the fact that the environment variables it tests are not already set (and fails otherwise); therefore, reverting to the original state should fix this. Fixes: #21451 Fixes: nodejs/build#1377 Refs: #25219 PR-URL: #25226 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
1 parent b17819d commit fbafe8d

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed
 

‎test/parallel/test-repl-envvars.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ const tests = [
3636
];
3737

3838
function run(test) {
39-
const env = Object.assign({}, process.env, test.env);
39+
const env = test.env;
4040
const expected = test.expected;
4141
const opts = {
4242
terminal: true,

0 commit comments

Comments
 (0)
Please sign in to comment.