Skip to content

Commit fba06eb

Browse files
committedAug 16, 2024
deps: remove bogus V8 DCHECK
Refs: #54077 (comment) PR-URL: #54077 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
1 parent 5355603 commit fba06eb

File tree

2 files changed

+1
-2
lines changed

2 files changed

+1
-2
lines changed
 

Diff for: ‎common.gypi

+1-1
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636

3737
# Reset this number to 0 on major V8 upgrades.
3838
# Increment by one for each non-official patch applied to deps/v8.
39-
'v8_embedder_string': '-node.12',
39+
'v8_embedder_string': '-node.13',
4040

4141
##### V8 defaults for Node.js #####
4242

Diff for: ‎deps/v8/src/ast/scopes.cc

-1
Original file line numberDiff line numberDiff line change
@@ -2714,7 +2714,6 @@ void Scope::AllocateScopeInfosRecursively(
27142714

27152715
// Allocate ScopeInfos for inner scopes.
27162716
for (Scope* scope = inner_scope_; scope != nullptr; scope = scope->sibling_) {
2717-
DCHECK_GT(scope->UniqueIdInScript(), UniqueIdInScript());
27182717
DCHECK_IMPLIES(scope->sibling_, scope->sibling_->UniqueIdInScript() !=
27192718
scope->UniqueIdInScript());
27202719
if (!scope->is_function_scope() ||

0 commit comments

Comments
 (0)
Please sign in to comment.