Skip to content

Commit f626acc

Browse files
committedAug 16, 2024
deps: silence internal V8 deprecation warning
PR-URL: #52293 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> PR-URL: #54077 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
1 parent ed187fa commit f626acc

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed
 

Diff for: ‎common.gypi

+1-1
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636

3737
# Reset this number to 0 on major V8 upgrades.
3838
# Increment by one for each non-official patch applied to deps/v8.
39-
'v8_embedder_string': '-node.4',
39+
'v8_embedder_string': '-node.5',
4040

4141
##### V8 defaults for Node.js #####
4242

Diff for: ‎deps/v8/src/base/optional.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ namespace base {
1616

1717
// These aliases are deprecated, use std::optional directly.
1818
template <typename T>
19-
using Optional [[deprecated]] = std::optional<T>;
19+
using Optional = std::optional<T>;
2020

2121
using std::in_place;
2222
using std::make_optional;

0 commit comments

Comments
 (0)
Please sign in to comment.