Skip to content

Commit e945bd9

Browse files
committedAug 16, 2024
src: update NODE_MODULE_VERSION to 129
Major V8 updates are usually API/ABI incompatible with previous versions. This commit adapts NODE_MODULE_VERSION for V8 12.8. Refs: https://github.com/nodejs/CTC/blob/master/meetings/2016-09-28.md PR-URL: #54077 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
1 parent 1dfa3b8 commit e945bd9

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed
 

Diff for: ‎doc/abi_version_registry.json

+3-2
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
11
{
22
"NODE_MODULE_VERSION": [
3-
{ "modules": 128, "runtime":"electron", "variant": "electron", "versions": "32" },
4-
{ "modules": 127, "runtime":"node", "variant": "v8_12.4", "versions": "22.0.0" },
3+
{ "modules": 129,"runtime": "node", "variant": "v8_12.8", "versions": "23.0.0-pre" },
4+
{ "modules": 128,"runtime": "electron", "variant": "electron", "versions": "32" },
5+
{ "modules": 127,"runtime": "node", "variant": "v8_12.4", "versions": "22.0.0" },
56
{ "modules": 126,"runtime": "node", "variant": "v8_12.3", "versions": "22.0.0-pre" },
67
{ "modules": 125,"runtime": "electron", "variant": "electron", "versions": "31" },
78
{ "modules": 124,"runtime": "node", "variant": "v8_12.2", "versions": "22.0.0-pre" },

Diff for: ‎src/node_version.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@
9595
#if defined(NODE_EMBEDDER_MODULE_VERSION)
9696
#define NODE_MODULE_VERSION NODE_EMBEDDER_MODULE_VERSION
9797
#else
98-
#define NODE_MODULE_VERSION 127
98+
#define NODE_MODULE_VERSION 129
9999
#endif
100100

101101
// The NAPI_VERSION supported by the runtime. This is the inclusive range of

0 commit comments

Comments
 (0)
Please sign in to comment.