Skip to content

Commit dfff614

Browse files
targosnodejs-github-bot
authored andcommittedSep 19, 2024
deps: disable V8 concurrent sparkplug compilation
It introduces process hangs on some platforms because Node.js doesn't tear down V8 correctly. Disable it while we work on a solution. Refs: #47297 Refs: https://bugs.chromium.org/p/v8/issues/detail?id=13902 PR-URL: #47450 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> PR-URL: #54536 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
1 parent 69ad89f commit dfff614

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed
 

Diff for: ‎common.gypi

+1-1
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636

3737
# Reset this number to 0 on major V8 upgrades.
3838
# Increment by one for each non-official patch applied to deps/v8.
39-
'v8_embedder_string': '-node.1',
39+
'v8_embedder_string': '-node.2',
4040

4141
##### V8 defaults for Node.js #####
4242

Diff for: ‎deps/v8/src/flags/flag-definitions.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -1009,7 +1009,7 @@ DEFINE_BOOL(baseline_batch_compilation, true, "batch compile Sparkplug code")
10091009
DEFINE_BOOL_READONLY(concurrent_sparkplug, false,
10101010
"compile Sparkplug code in a background thread")
10111011
#else
1012-
DEFINE_BOOL(concurrent_sparkplug, ENABLE_SPARKPLUG_BY_DEFAULT,
1012+
DEFINE_BOOL(concurrent_sparkplug, false,
10131013
"compile Sparkplug code in a background thread")
10141014
DEFINE_WEAK_IMPLICATION(future, concurrent_sparkplug)
10151015
DEFINE_NEG_IMPLICATION(predictable, concurrent_sparkplug)

0 commit comments

Comments
 (0)
Please sign in to comment.