Skip to content

Commit dc4e702

Browse files
StefanStojanovictargos
authored andcommittedAug 16, 2024
deps: patch V8 to support compilation with MSVC
After enabling -std:c++20 on Windows, patch is now much smaller. PR-URL: #52465 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> PR-URL: #54077 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
1 parent f626acc commit dc4e702

File tree

2 files changed

+1
-3
lines changed

2 files changed

+1
-3
lines changed
 

Diff for: ‎common.gypi

+1-1
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636

3737
# Reset this number to 0 on major V8 upgrades.
3838
# Increment by one for each non-official patch applied to deps/v8.
39-
'v8_embedder_string': '-node.5',
39+
'v8_embedder_string': '-node.6',
4040

4141
##### V8 defaults for Node.js #####
4242

Diff for: ‎deps/v8/src/objects/tagged-field.h

-2
Original file line numberDiff line numberDiff line change
@@ -100,12 +100,10 @@ static_assert(sizeof(UnalignedDoubleMember) == sizeof(double));
100100
#define FLEXIBLE_ARRAY_MEMBER(Type, name) \
101101
using FlexibleDataReturnType = Type[0]; \
102102
FlexibleDataReturnType& name() { \
103-
static_assert(alignof(Type) <= alignof(decltype(*this))); \
104103
using ReturnType = Type[0]; \
105104
return reinterpret_cast<ReturnType&>(*(this + 1)); \
106105
} \
107106
const FlexibleDataReturnType& name() const { \
108-
static_assert(alignof(Type) <= alignof(decltype(*this))); \
109107
using ReturnType = Type[0]; \
110108
return reinterpret_cast<const ReturnType&>(*(this + 1)); \
111109
} \

0 commit comments

Comments
 (0)