Skip to content

Commit d86f247

Browse files
jazellytargos
authored andcommittedOct 2, 2024
lib: make WeakRef safe in abort_controller
PR-URL: #54791 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
1 parent 85542b0 commit d86f247

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed
 

‎lib/internal/abort_controller.js

+4-4
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,9 @@ const {
1111
PromiseResolve,
1212
SafeFinalizationRegistry,
1313
SafeSet,
14+
SafeWeakRef,
1415
Symbol,
1516
SymbolToStringTag,
16-
WeakRef,
1717
} = primordials;
1818

1919
const {
@@ -188,7 +188,7 @@ class AbortSignal extends EventTarget {
188188
signal[kTimeout] = true;
189189
clearTimeoutRegistry.register(
190190
signal,
191-
setWeakAbortSignalTimeout(new WeakRef(signal), delay));
191+
setWeakAbortSignalTimeout(new SafeWeakRef(signal), delay));
192192
return signal;
193193
}
194194

@@ -202,7 +202,7 @@ class AbortSignal extends EventTarget {
202202
if (!signals.length) {
203203
return resultSignal;
204204
}
205-
const resultSignalWeakRef = new WeakRef(resultSignal);
205+
const resultSignalWeakRef = new SafeWeakRef(resultSignal);
206206
resultSignal[kSourceSignals] = new SafeSet();
207207
for (let i = 0; i < signals.length; i++) {
208208
const signal = signals[i];
@@ -212,7 +212,7 @@ class AbortSignal extends EventTarget {
212212
}
213213
signal[kDependantSignals] ??= new SafeSet();
214214
if (!signal[kComposite]) {
215-
resultSignal[kSourceSignals].add(new WeakRef(signal));
215+
resultSignal[kSourceSignals].add(new SafeWeakRef(signal));
216216
signal[kDependantSignals].add(resultSignalWeakRef);
217217
} else if (!signal[kSourceSignals]) {
218218
continue;

0 commit comments

Comments
 (0)
Please sign in to comment.