lib: prefer optional chaining

PR-URL: #55045
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>

Author: avivkeller

eslint.config.mjs

@@ -313,6 +313,7 @@ export default [
       'node-core/no-unescaped-regexp-dot': 'error',
       'node-core/no-duplicate-requires': 'error',
       'node-core/prefer-proto': 'error',
+      'node-core/prefer-optional-chaining': 'error',
     },
   },
   // #endregion

lib/_http_agent.js

@@ -128,7 +128,7 @@ function Agent(options) {
     }
 
     const requests = this.requests[name];
-    if (requests && requests.length) {
+    if (requests?.length) {
       const req = requests.shift();
       const reqAsyncRes = req[kRequestAsyncResource];
       if (reqAsyncRes) {
@@ -437,7 +437,7 @@ Agent.prototype.removeSocket = function removeSocket(s, options) {
   }
 
   let req;
-  if (this.requests[name] && this.requests[name].length) {
+  if (this.requests[name]?.length) {
     debug('removeSocket, have a request, make a socket');
     req = this.requests[name][0];
   } else {
@@ -449,7 +449,7 @@ Agent.prototype.removeSocket = function removeSocket(s, options) {
     for (let i = 0; i < keys.length; i++) {
       const prop = keys[i];
       // Check whether this specific origin is already at maxSockets
-      if (this.sockets[prop] && this.sockets[prop].length) break;
+      if (this.sockets[prop]?.length) break;
       debug('removeSocket, have a request with different origin,' +
         ' make a socket');
       req = this.requests[prop][0];