Skip to content

Commit ccc676a

Browse files
UlisesGasconmarco-ippolito
authored andcommittedFeb 12, 2024
tools: use macOS keychain to notarize the releases
PR-URL: #50715 Reviewed-By: Michael Dawson <midawson@redhat.com>
1 parent 31f1ceb commit ccc676a

File tree

1 file changed

+1
-6
lines changed

1 file changed

+1
-6
lines changed
 

‎tools/osx-notarize.sh

+1-6
Original file line numberDiff line numberDiff line change
@@ -34,15 +34,10 @@ then
3434
exit 1
3535
fi
3636

37-
# Submit the package for notarization
38-
# TODO(@ulisesGascon): refactor to use --keychain-profile
39-
# when https://github.com/nodejs/build/issues/3385#issuecomment-1729281269 is ready
4037
echo "Submitting node-$pkgid.pkg for notarization..."
4138

4239
xcrun notarytool submit \
43-
--apple-id "$NOTARIZATION_ID" \
44-
--password "$NOTARIZATION_PASSWORD" \
45-
--team-id "$NOTARIZATION_TEAM_ID" \
40+
--keychain-profile "NODE_RELEASE_PROFILE" \
4641
--wait \
4742
"node-$pkgid.pkg"
4843

0 commit comments

Comments
 (0)
Please sign in to comment.