Skip to content

Commit cc36db7

Browse files
committedAug 16, 2024
deps: always define V8_EXPORT_PRIVATE as no-op
dllexport introduces issues when compiling with MSVC. PR-URL: #47251 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> PR-URL: #54077 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
1 parent e945bd9 commit cc36db7

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed
 

Diff for: ‎common.gypi

+1-1
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636

3737
# Reset this number to 0 on major V8 upgrades.
3838
# Increment by one for each non-official patch applied to deps/v8.
39-
'v8_embedder_string': '-node.0',
39+
'v8_embedder_string': '-node.1',
4040

4141
##### V8 defaults for Node.js #####
4242

Diff for: ‎deps/v8/src/base/macros.h

+4-4
Original file line numberDiff line numberDiff line change
@@ -401,9 +401,9 @@ bool is_inbounds(float_t v) {
401401
// Setup for Windows shared library export.
402402
#define V8_EXPORT_ENUM
403403
#ifdef BUILDING_V8_SHARED_PRIVATE
404-
#define V8_EXPORT_PRIVATE __declspec(dllexport)
404+
#define V8_EXPORT_PRIVATE
405405
#elif USING_V8_SHARED_PRIVATE
406-
#define V8_EXPORT_PRIVATE __declspec(dllimport)
406+
#define V8_EXPORT_PRIVATE
407407
#else
408408
#define V8_EXPORT_PRIVATE
409409
#endif // BUILDING_V8_SHARED
@@ -413,8 +413,8 @@ bool is_inbounds(float_t v) {
413413
// Setup for Linux shared library export.
414414
#if V8_HAS_ATTRIBUTE_VISIBILITY
415415
#ifdef BUILDING_V8_SHARED_PRIVATE
416-
#define V8_EXPORT_PRIVATE __attribute__((visibility("default")))
417-
#define V8_EXPORT_ENUM V8_EXPORT_PRIVATE
416+
#define V8_EXPORT_PRIVATE
417+
#define V8_EXPORT_ENUM
418418
#else
419419
#define V8_EXPORT_PRIVATE
420420
#define V8_EXPORT_ENUM

0 commit comments

Comments
 (0)
Please sign in to comment.