Skip to content

Commit be528ab

Browse files
marco-ippolitonodejs-github-bot
authored andcommittedMay 6, 2024
util: move util.isBoolean to eol
PR-URL: #52744 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent ac97a53 commit be528ab

File tree

4 files changed

+5
-45
lines changed

4 files changed

+5
-45
lines changed
 

Diff for: ‎doc/api/deprecations.md

+5-3
Original file line numberDiff line numberDiff line change
@@ -996,6 +996,9 @@ instead.
996996

997997
<!-- YAML
998998
changes:
999+
- version: REPLACEME
1000+
pr-url: https://github.com/nodejs/node/pull/52744
1001+
description: End-of-Life deprecation.
9991002
- version: v22.0.0
10001003
pr-url: https://github.com/nodejs/node/pull/50488
10011004
description: Runtime deprecation.
@@ -1011,9 +1014,9 @@ changes:
10111014
description: Documentation-only deprecation.
10121015
-->
10131016

1014-
Type: Runtime
1017+
Type: End-of-Life
10151018

1016-
The [`util.isBoolean()`][] API is deprecated. Please use
1019+
The `util.isBoolean()` API has been removed. Please use
10171020
`typeof arg === 'boolean'` instead.
10181021

10191022
### DEP0046: `util.isBuffer()`
@@ -3776,7 +3779,6 @@ is deprecated to better align with recommendations per [NIST SP 800-38D][].
37763779
[`util.inspect()`]: util.md#utilinspectobject-options
37773780
[`util.inspect.custom`]: util.md#utilinspectcustom
37783781
[`util.isArray()`]: util.md#utilisarrayobject
3779-
[`util.isBoolean()`]: util.md#utilisbooleanobject
37803782
[`util.isBuffer()`]: util.md#utilisbufferobject
37813783
[`util.isDate()`]: util.md#utilisdateobject
37823784
[`util.isError()`]: util.md#utiliserrorobject

Diff for: ‎doc/api/util.md

-25
Original file line numberDiff line numberDiff line change
@@ -2950,31 +2950,6 @@ util.isArray({});
29502950
// Returns: false
29512951
```
29522952
2953-
### `util.isBoolean(object)`
2954-
2955-
<!-- YAML
2956-
added: v0.11.5
2957-
deprecated: v4.0.0
2958-
-->
2959-
2960-
> Stability: 0 - Deprecated: Use `typeof value === 'boolean'` instead.
2961-
2962-
* `object` {any}
2963-
* Returns: {boolean}
2964-
2965-
Returns `true` if the given `object` is a `Boolean`. Otherwise, returns `false`.
2966-
2967-
```js
2968-
const util = require('node:util');
2969-
2970-
util.isBoolean(1);
2971-
// Returns: false
2972-
util.isBoolean(0);
2973-
// Returns: false
2974-
util.isBoolean(false);
2975-
// Returns: true
2976-
```
2977-
29782953
### `util.isBuffer(object)`
29792954
29802955
<!-- YAML

Diff for: ‎lib/util.js

-12
Original file line numberDiff line numberDiff line change
@@ -91,15 +91,6 @@ function lazyAbortController() {
9191

9292
let internalDeepEqual;
9393

94-
/**
95-
* @deprecated since v4.0.0
96-
* @param {any} arg
97-
* @returns {arg is boolean}
98-
*/
99-
function isBoolean(arg) {
100-
return typeof arg === 'boolean';
101-
}
102-
10394
/**
10495
* @deprecated since v4.0.0
10596
* @param {any} arg
@@ -419,9 +410,6 @@ module.exports = {
419410
isArray: deprecate(ArrayIsArray,
420411
'The `util.isArray` API is deprecated. Please use `Array.isArray()` instead.',
421412
'DEP0044'),
422-
isBoolean: deprecate(isBoolean,
423-
'The `util.isBoolean` API is deprecated. Please use `typeof arg === "boolean"` instead.',
424-
'DEP0045'),
425413
isBuffer: deprecate(isBuffer,
426414
'The `util.isBuffer` API is deprecated. Please use `Buffer.isBuffer()` instead.',
427415
'DEP0046'),

Diff for: ‎test/parallel/test-util.js

-5
Original file line numberDiff line numberDiff line change
@@ -102,11 +102,6 @@ assert.strictEqual(util.isPrimitive(Symbol('symbol')), true);
102102
assert.strictEqual(util.isBuffer('foo'), false);
103103
assert.strictEqual(util.isBuffer(Buffer.from('foo')), true);
104104

105-
// deprecated
106-
assert.strictEqual(util.isBoolean(true), true);
107-
assert.strictEqual(util.isBoolean(false), true);
108-
assert.strictEqual(util.isBoolean('string'), false);
109-
110105
assert.strictEqual(util.isNull(null), true);
111106
assert.strictEqual(util.isNull(undefined), false);
112107
assert.strictEqual(util.isNull(), false);

0 commit comments

Comments
 (0)
Please sign in to comment.