Skip to content

Commit b5cae4f

Browse files
marco-ippolitonodejs-github-bot
authored andcommittedMay 6, 2024
util: move util.isDate to eol
PR-URL: #52744 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent bd559e3 commit b5cae4f

File tree

4 files changed

+5
-41
lines changed

4 files changed

+5
-41
lines changed
 

Diff for: ‎doc/api/deprecations.md

+5-2
Original file line numberDiff line numberDiff line change
@@ -1050,6 +1050,9 @@ The `util.isBuffer()` API has been removed. Please use
10501050

10511051
<!-- YAML
10521052
changes:
1053+
- version: REPLACEME
1054+
pr-url: https://github.com/nodejs/node/pull/52744
1055+
description: End-of-Life deprecation.
10531056
- version: v22.0.0
10541057
pr-url: https://github.com/nodejs/node/pull/50488
10551058
description: Runtime deprecation.
@@ -1065,9 +1068,9 @@ changes:
10651068
description: Documentation-only deprecation.
10661069
-->
10671070

1068-
Type: Runtime
1071+
Type: End-of-Life
10691072

1070-
The [`util.isDate()`][] API is deprecated. Please use
1073+
The `util.isDate()` API has been removed. Please use
10711074
`arg instanceof Date` instead.
10721075

10731076
### DEP0048: `util.isError()`

Diff for: ‎doc/api/util.md

-26
Original file line numberDiff line numberDiff line change
@@ -2950,31 +2950,6 @@ util.isArray({});
29502950
// Returns: false
29512951
```
29522952
2953-
### `util.isDate(object)`
2954-
2955-
<!-- YAML
2956-
added: v0.6.0
2957-
deprecated: v4.0.0
2958-
-->
2959-
2960-
> Stability: 0 - Deprecated: Use [`util.types.isDate()`][] instead.
2961-
2962-
* `object` {any}
2963-
* Returns: {boolean}
2964-
2965-
Returns `true` if the given `object` is a `Date`. Otherwise, returns `false`.
2966-
2967-
```js
2968-
const util = require('node:util');
2969-
2970-
util.isDate(new Date());
2971-
// Returns: true
2972-
util.isDate(Date());
2973-
// false (without 'new' returns a String)
2974-
util.isDate({});
2975-
// Returns: false
2976-
```
2977-
29782953
### `util.isError(object)`
29792954
29802955
<!-- YAML
@@ -3152,7 +3127,6 @@ util.log('Timestamped message.');
31523127
[`util.promisify()`]: #utilpromisifyoriginal
31533128
[`util.types.isAnyArrayBuffer()`]: #utiltypesisanyarraybuffervalue
31543129
[`util.types.isArrayBuffer()`]: #utiltypesisarraybuffervalue
3155-
[`util.types.isDate()`]: #utiltypesisdatevalue
31563130
[`util.types.isNativeError()`]: #utiltypesisnativeerrorvalue
31573131
[`util.types.isSharedArrayBuffer()`]: #utiltypesissharedarraybuffervalue
31583132
[async function]: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/async_function

Diff for: ‎lib/util.js

-3
Original file line numberDiff line numberDiff line change
@@ -354,9 +354,6 @@ module.exports = {
354354
}
355355
return internalDeepEqual(a, b);
356356
},
357-
isDate: deprecate(types.isDate,
358-
'The `util.isDate` API is deprecated. Please use `arg instanceof Date` instead.',
359-
'DEP0047'),
360357
isError: deprecate(isError,
361358
'The `util.isError` API is deprecated. ' +
362359
'Please use `ObjectPrototypeToString(e) === "[object Error]" ' +

Diff for: ‎test/parallel/test-util.js

-10
Original file line numberDiff line numberDiff line change
@@ -40,16 +40,6 @@ assert.strictEqual(util.isArray(/regexp/), false);
4040
assert.strictEqual(util.isArray(new Error()), false);
4141
assert.strictEqual(util.isArray({ __proto__: Array.prototype }), false);
4242

43-
// isDate
44-
assert.strictEqual(util.isDate(new Date()), true);
45-
assert.strictEqual(util.isDate(new Date(0), 'foo'), true);
46-
assert.strictEqual(util.isDate(new (context('Date'))()), true);
47-
assert.strictEqual(util.isDate(Date()), false);
48-
assert.strictEqual(util.isDate({}), false);
49-
assert.strictEqual(util.isDate([]), false);
50-
assert.strictEqual(util.isDate(new Error()), false);
51-
assert.strictEqual(util.isDate({ __proto__: Date.prototype }), false);
52-
5343
// isError
5444
assert.strictEqual(util.isError(new Error()), true);
5545
assert.strictEqual(util.isError(new TypeError()), true);

0 commit comments

Comments
 (0)
Please sign in to comment.