Skip to content

Commit 97c4907

Browse files
joyeecheungshnooshnoo
authored andcommittedFeb 12, 2024
test: skip test-child-process-stdio-reuse-readable-stdio on Windows
It is flaky due to the same cause of test-child-process-pipe-dataflow being flaky - cygwin quirks - so skip it on Windows too. Drive-by: remove the skip mark of test-child-process-pipe-dataflow in the status file and directly skip it in the test with a comment. PR-URL: #49621 Backport-PR-URL: #51132 Co-authored-by: Artur Yapparov <arturufa88@gmail.com> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
1 parent 6cdc71b commit 97c4907

3 files changed

+12
-3
lines changed
 

‎test/parallel/parallel.status

-3
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,6 @@ prefix parallel
1111
test-crypto-keygen: PASS,FLAKY
1212
# https://github.com/nodejs/node/issues/41201
1313
test-fs-rmdir-recursive: PASS, FLAKY
14-
# https://github.com/nodejs/node/issues/48300
15-
test-child-process-pipe-dataflow: PASS, FLAKY
16-
test-child-process-stdio-reuse-readable-stdio: PASS, FLAKY
1714
# https://github.com/nodejs/node/issues/49985
1815
test-runner-watch-mode: PASS, FLAKY
1916
# https://github.com/nodejs/node/issues/50295

‎test/parallel/test-child-process-pipe-dataflow.js

+6
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,11 @@
11
'use strict';
22
const common = require('../common');
3+
4+
if (common.isWindows) {
5+
// https://github.com/nodejs/node/issues/48300
6+
common.skip('Does not work with cygwin quirks on Windows');
7+
}
8+
39
const assert = require('assert');
410
const path = require('path');
511
const fs = require('fs');

‎test/parallel/test-child-process-stdio-reuse-readable-stdio.js

+6
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,11 @@
11
'use strict';
22
const common = require('../common');
3+
4+
if (common.isWindows) {
5+
// https://github.com/nodejs/node/issues/48300
6+
common.skip('Does not work with cygwin quirks on Windows');
7+
}
8+
39
const assert = require('assert');
410
const { spawn } = require('child_process');
511

0 commit comments

Comments
 (0)
Please sign in to comment.