Skip to content

Commit 8e33f20

Browse files
authoredJun 25, 2024··
Revert "deps: V8: cherry-pick 9ebca66a5740"
Reason for revert: broke test-snapshot-reproducible.js in dynamically linked builds in the CI. This reverts commit 4c730ae. PR-URL: #53582 Refs: #53579 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Stewart X Addison <sxa@redhat.com>
1 parent d7d9278 commit 8e33f20

File tree

58 files changed

+204
-71
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

58 files changed

+204
-71
lines changed
 

Diff for: ‎common.gypi

+1-1
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636

3737
# Reset this number to 0 on major V8 upgrades.
3838
# Increment by one for each non-official patch applied to deps/v8.
39-
'v8_embedder_string': '-node.16',
39+
'v8_embedder_string': '-node.15',
4040

4141
##### V8 defaults for Node.js #####
4242

Diff for: ‎deps/v8/src/api/api.cc

+3
Original file line numberDiff line numberDiff line change
@@ -8953,6 +8953,9 @@ std::unique_ptr<v8::BackingStore> v8::ArrayBuffer::NewBackingStore(
89538953
// static
89548954
std::unique_ptr<BackingStore> v8::ArrayBuffer::NewResizableBackingStore(
89558955
size_t byte_length, size_t max_byte_length) {
8956+
Utils::ApiCheck(i::v8_flags.harmony_rab_gsab,
8957+
"v8::ArrayBuffer::NewResizableBackingStore",
8958+
"Constructing resizable ArrayBuffers is not supported");
89568959
Utils::ApiCheck(byte_length <= max_byte_length,
89578960
"v8::ArrayBuffer::NewResizableBackingStore",
89588961
"Cannot construct resizable ArrayBuffer, byte_length must be "

0 commit comments

Comments
 (0)
Please sign in to comment.