Skip to content

Commit 762a440

Browse files
targosnodejs-github-bot
authored andcommittedSep 19, 2024
deps: patch V8 to support older Clang versions
PR-URL: #54536 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
1 parent 95f2213 commit 762a440

File tree

2 files changed

+7
-6
lines changed

2 files changed

+7
-6
lines changed
 

Diff for: ‎common.gypi

+1-1
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636

3737
# Reset this number to 0 on major V8 upgrades.
3838
# Increment by one for each non-official patch applied to deps/v8.
39-
'v8_embedder_string': '-node.6',
39+
'v8_embedder_string': '-node.7',
4040

4141
##### V8 defaults for Node.js #####
4242

Diff for: ‎deps/v8/src/compiler/turboshaft/assembler.h

+6-5
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
#ifndef V8_COMPILER_TURBOSHAFT_ASSEMBLER_H_
66
#define V8_COMPILER_TURBOSHAFT_ASSEMBLER_H_
77

8+
#include <concepts>
89
#include <cstring>
910
#include <iomanip>
1011
#include <iterator>
@@ -197,8 +198,8 @@ template <typename T>
197198
class IndexRange : public Range<T> {
198199
public:
199200
using base = Range<T>;
200-
using value_type = base::value_type;
201-
using iterator_type = base::iterator_type;
201+
using value_type = typename base::value_type;
202+
using iterator_type = typename base::iterator_type;
202203

203204
explicit IndexRange(ConstOrV<T> count) : Range<T>(0, count, 1) {}
204205
};
@@ -226,8 +227,8 @@ class Sequence : private Range<T> {
226227
using base = Range<T>;
227228

228229
public:
229-
using value_type = base::value_type;
230-
using iterator_type = base::iterator_type;
230+
using value_type = typename base::value_type;
231+
using iterator_type = typename base::iterator_type;
231232

232233
explicit Sequence(ConstOrV<T> begin, ConstOrV<T> stride = 1)
233234
: base(begin, 0, stride) {}
@@ -731,7 +732,7 @@ struct LoopLabelForHelper<std::tuple<V<Ts>...>> {
731732
} // namespace detail
732733

733734
template <typename T>
734-
using LoopLabelFor = detail::LoopLabelForHelper<T>::type;
735+
using LoopLabelFor = typename detail::LoopLabelForHelper<T>::type;
735736

736737
Handle<Code> BuiltinCodeHandle(Builtin builtin, Isolate* isolate);
737738

0 commit comments

Comments
 (0)
Please sign in to comment.