Skip to content

Commit 708f57e

Browse files
marco-ippolitonodejs-github-bot
authored andcommittedMay 6, 2024
util: move util.isNumber to eol
PR-URL: #52744 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent 6ec403f commit 708f57e

File tree

4 files changed

+5
-46
lines changed

4 files changed

+5
-46
lines changed
 

Diff for: ‎doc/api/deprecations.md

+5-3
Original file line numberDiff line numberDiff line change
@@ -1177,6 +1177,9 @@ The `util.isNullOrUndefined()` API has been removed. Please use
11771177

11781178
<!-- YAML
11791179
changes:
1180+
- version: REPLACEME
1181+
pr-url: https://github.com/nodejs/node/pull/52744
1182+
description: End-of-Life deprecation.
11801183
- version: v22.0.0
11811184
pr-url: https://github.com/nodejs/node/pull/50488
11821185
description: Runtime deprecation.
@@ -1192,9 +1195,9 @@ changes:
11921195
description: Documentation-only deprecation.
11931196
-->
11941197

1195-
Type: Runtime
1198+
Type: End-of-Life
11961199

1197-
The [`util.isNumber()`][] API is deprecated. Please use
1200+
The `util.isNumber()` API has been removed. Please use
11981201
`typeof arg === 'number'` instead.
11991202

12001203
### DEP0053: `util.isObject()`
@@ -3790,7 +3793,6 @@ is deprecated to better align with recommendations per [NIST SP 800-38D][].
37903793
[`util.isArray()`]: util.md#utilisarrayobject
37913794
[`util.isError()`]: util.md#utiliserrorobject
37923795
[`util.isFunction()`]: util.md#utilisfunctionobject
3793-
[`util.isNumber()`]: util.md#utilisnumberobject
37943796
[`util.isObject()`]: util.md#utilisobjectobject
37953797
[`util.isPrimitive()`]: util.md#utilisprimitiveobject
37963798
[`util.isRegExp()`]: util.md#utilisregexpobject

Diff for: ‎doc/api/util.md

-27
Original file line numberDiff line numberDiff line change
@@ -3045,33 +3045,6 @@ util.isFunction(Bar);
30453045
// Returns: true
30463046
```
30473047
3048-
### `util.isNumber(object)`
3049-
3050-
<!-- YAML
3051-
added: v0.11.5
3052-
deprecated: v4.0.0
3053-
-->
3054-
3055-
> Stability: 0 - Deprecated: Use `typeof value === 'number'` instead.
3056-
3057-
* `object` {any}
3058-
* Returns: {boolean}
3059-
3060-
Returns `true` if the given `object` is a `Number`. Otherwise, returns `false`.
3061-
3062-
```js
3063-
const util = require('node:util');
3064-
3065-
util.isNumber(false);
3066-
// Returns: false
3067-
util.isNumber(Infinity);
3068-
// Returns: true
3069-
util.isNumber(0);
3070-
// Returns: true
3071-
util.isNumber(NaN);
3072-
// Returns: true
3073-
```
3074-
30753048
### `util.isObject(object)`
30763049
30773050
<!-- YAML

Diff for: ‎lib/util.js

-12
Original file line numberDiff line numberDiff line change
@@ -90,15 +90,6 @@ function lazyAbortController() {
9090

9191
let internalDeepEqual;
9292

93-
/**
94-
* @deprecated since v4.0.0
95-
* @param {any} arg
96-
* @returns {arg is number}
97-
*/
98-
function isNumber(arg) {
99-
return typeof arg === 'number';
100-
}
101-
10293
/**
10394
* @param {any} arg
10495
* @returns {arg is string}
@@ -398,9 +389,6 @@ module.exports = {
398389
}
399390
return internalDeepEqual(a, b);
400391
},
401-
isNumber: deprecate(isNumber,
402-
'The `util.isNumber` API is deprecated. Please use `typeof arg === "number"` instead.',
403-
'DEP0052'),
404392
isString: deprecate(isString,
405393
'The `util.isString` API is deprecated. Please use `typeof arg === "string"` instead.',
406394
'DEP0056'),

Diff for: ‎test/parallel/test-util.js

-4
Original file line numberDiff line numberDiff line change
@@ -103,10 +103,6 @@ assert.strictEqual(util.isUndefined(), true);
103103
assert.strictEqual(util.isUndefined(null), false);
104104
assert.strictEqual(util.isUndefined('string'), false);
105105

106-
assert.strictEqual(util.isNumber(42), true);
107-
assert.strictEqual(util.isNumber(), false);
108-
assert.strictEqual(util.isNumber('string'), false);
109-
110106
assert.strictEqual(util.isString('string'), true);
111107
assert.strictEqual(util.isString(), false);
112108
assert.strictEqual(util.isString(42), false);

0 commit comments

Comments
 (0)
Please sign in to comment.