Skip to content

Commit 6ec403f

Browse files
marco-ippolitonodejs-github-bot
authored andcommittedMay 6, 2024
util: move util.isNullOrUndefined to eol
PR-URL: #52744 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent 7cd8bb2 commit 6ec403f

File tree

4 files changed

+5
-48
lines changed

4 files changed

+5
-48
lines changed
 

Diff for: ‎doc/api/deprecations.md

+5-3
Original file line numberDiff line numberDiff line change
@@ -1150,6 +1150,9 @@ The `util.isNull()` API has been removed. Please use
11501150

11511151
<!-- YAML
11521152
changes:
1153+
- version: REPLACEME
1154+
pr-url: https://github.com/nodejs/node/pull/52744
1155+
description: End-of-Life deprecation.
11531156
- version: v22.0.0
11541157
pr-url: https://github.com/nodejs/node/pull/50488
11551158
description: Runtime deprecation.
@@ -1165,9 +1168,9 @@ changes:
11651168
description: Documentation-only deprecation.
11661169
-->
11671170

1168-
Type: Runtime
1171+
Type: End-of-Life
11691172

1170-
The [`util.isNullOrUndefined()`][] API is deprecated. Please use
1173+
The `util.isNullOrUndefined()` API has been removed. Please use
11711174
`arg === null || arg === undefined` instead.
11721175

11731176
### DEP0052: `util.isNumber()`
@@ -3787,7 +3790,6 @@ is deprecated to better align with recommendations per [NIST SP 800-38D][].
37873790
[`util.isArray()`]: util.md#utilisarrayobject
37883791
[`util.isError()`]: util.md#utiliserrorobject
37893792
[`util.isFunction()`]: util.md#utilisfunctionobject
3790-
[`util.isNullOrUndefined()`]: util.md#utilisnullorundefinedobject
37913793
[`util.isNumber()`]: util.md#utilisnumberobject
37923794
[`util.isObject()`]: util.md#utilisobjectobject
37933795
[`util.isPrimitive()`]: util.md#utilisprimitiveobject

Diff for: ‎doc/api/util.md

-27
Original file line numberDiff line numberDiff line change
@@ -3045,33 +3045,6 @@ util.isFunction(Bar);
30453045
// Returns: true
30463046
```
30473047
3048-
### `util.isNullOrUndefined(object)`
3049-
3050-
<!-- YAML
3051-
added: v0.11.5
3052-
deprecated: v4.0.0
3053-
-->
3054-
3055-
> Stability: 0 - Deprecated: Use
3056-
> `value === undefined || value === null` instead.
3057-
3058-
* `object` {any}
3059-
* Returns: {boolean}
3060-
3061-
Returns `true` if the given `object` is `null` or `undefined`. Otherwise,
3062-
returns `false`.
3063-
3064-
```js
3065-
const util = require('node:util');
3066-
3067-
util.isNullOrUndefined(0);
3068-
// Returns: false
3069-
util.isNullOrUndefined(undefined);
3070-
// Returns: true
3071-
util.isNullOrUndefined(null);
3072-
// Returns: true
3073-
```
3074-
30753048
### `util.isNumber(object)`
30763049
30773050
<!-- YAML

Diff for: ‎lib/util.js

-13
Original file line numberDiff line numberDiff line change
@@ -90,15 +90,6 @@ function lazyAbortController() {
9090

9191
let internalDeepEqual;
9292

93-
/**
94-
* @deprecated since v4.0.0
95-
* @param {any} arg
96-
* @returns {arg is (null | undefined)}
97-
*/
98-
function isNullOrUndefined(arg) {
99-
return arg === null || arg === undefined;
100-
}
101-
10293
/**
10394
* @deprecated since v4.0.0
10495
* @param {any} arg
@@ -407,10 +398,6 @@ module.exports = {
407398
}
408399
return internalDeepEqual(a, b);
409400
},
410-
isNullOrUndefined: deprecate(isNullOrUndefined,
411-
'The `util.isNullOrUndefined` API is deprecated. ' +
412-
'Please use `arg === null || arg === undefined` instead.',
413-
'DEP0051'),
414401
isNumber: deprecate(isNumber,
415402
'The `util.isNumber` API is deprecated. Please use `typeof arg === "number"` instead.',
416403
'DEP0052'),

Diff for: ‎test/parallel/test-util.js

-5
Original file line numberDiff line numberDiff line change
@@ -103,11 +103,6 @@ assert.strictEqual(util.isUndefined(), true);
103103
assert.strictEqual(util.isUndefined(null), false);
104104
assert.strictEqual(util.isUndefined('string'), false);
105105

106-
assert.strictEqual(util.isNullOrUndefined(null), true);
107-
assert.strictEqual(util.isNullOrUndefined(undefined), true);
108-
assert.strictEqual(util.isNullOrUndefined(), true);
109-
assert.strictEqual(util.isNullOrUndefined('string'), false);
110-
111106
assert.strictEqual(util.isNumber(42), true);
112107
assert.strictEqual(util.isNumber(), false);
113108
assert.strictEqual(util.isNumber('string'), false);

0 commit comments

Comments
 (0)
Please sign in to comment.