Skip to content

Commit 69ad89f

Browse files
targosnodejs-github-bot
authored andcommittedSep 19, 2024
deps: always define V8_EXPORT_PRIVATE as no-op
dllexport introduces issues when compiling with MSVC. PR-URL: #47251 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> PR-URL: #54536 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
1 parent 17a1716 commit 69ad89f

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed
 

Diff for: ‎common.gypi

+1-1
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636

3737
# Reset this number to 0 on major V8 upgrades.
3838
# Increment by one for each non-official patch applied to deps/v8.
39-
'v8_embedder_string': '-node.0',
39+
'v8_embedder_string': '-node.1',
4040

4141
##### V8 defaults for Node.js #####
4242

Diff for: ‎deps/v8/src/base/macros.h

+4-4
Original file line numberDiff line numberDiff line change
@@ -423,9 +423,9 @@ bool is_inbounds(float_t v) {
423423
// Setup for Windows shared library export.
424424
#define V8_EXPORT_ENUM
425425
#ifdef BUILDING_V8_SHARED_PRIVATE
426-
#define V8_EXPORT_PRIVATE __declspec(dllexport)
426+
#define V8_EXPORT_PRIVATE
427427
#elif USING_V8_SHARED_PRIVATE
428-
#define V8_EXPORT_PRIVATE __declspec(dllimport)
428+
#define V8_EXPORT_PRIVATE
429429
#else
430430
#define V8_EXPORT_PRIVATE
431431
#endif // BUILDING_V8_SHARED
@@ -435,8 +435,8 @@ bool is_inbounds(float_t v) {
435435
// Setup for Linux shared library export.
436436
#if V8_HAS_ATTRIBUTE_VISIBILITY
437437
#ifdef BUILDING_V8_SHARED_PRIVATE
438-
#define V8_EXPORT_PRIVATE __attribute__((visibility("default")))
439-
#define V8_EXPORT_ENUM V8_EXPORT_PRIVATE
438+
#define V8_EXPORT_PRIVATE
439+
#define V8_EXPORT_ENUM
440440
#else
441441
#define V8_EXPORT_PRIVATE
442442
#define V8_EXPORT_ENUM

0 commit comments

Comments
 (0)