Skip to content

Commit 5355603

Browse files
committedAug 16, 2024
deps: V8: cherry-pick 00e9eeb3fb2c
Original commit message: [base] include <vector> when std::vector is used It otherwise doesn't compile on Apple Clang 13. See #54077 Change-Id: I5dd41d98574f461ff7cf6d7d6ce5c71e240ad884 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5771451 Commit-Queue: Joyee Cheung <joyee@igalia.com> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/main@{#95557} Refs: v8/v8@00e9eeb PR-URL: #54077 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
1 parent bcc1e27 commit 5355603

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed
 

Diff for: ‎common.gypi

+1-1
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636

3737
# Reset this number to 0 on major V8 upgrades.
3838
# Increment by one for each non-official patch applied to deps/v8.
39-
'v8_embedder_string': '-node.11',
39+
'v8_embedder_string': '-node.12',
4040

4141
##### V8 defaults for Node.js #####
4242

Diff for: ‎deps/v8/src/base/logging.h

+1
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111
#include <sstream>
1212
#include <string>
1313
#include <utility>
14+
#include <vector>
1415

1516
#include "src/base/abort-mode.h"
1617
#include "src/base/base-export.h"

0 commit comments

Comments
 (0)