Skip to content

Commit 3f65598

Browse files
kvakilruyadorno
authored andcommittedSep 16, 2023
src: remove kEagerCompile for CompileFunction
It wasn't doing anything, and actually enabling it would cause some tests to fail. Refs: #48576 PR-URL: #48671 Refs: v8/v8@cb00db4 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
1 parent 3b8ec34 commit 3f65598

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed
 

‎src/node_builtins.cc

+1-1
Original file line numberDiff line numberDiff line change
@@ -297,7 +297,7 @@ MaybeLocal<Function> BuiltinLoader::LookupAndCompileInternal(
297297
const bool has_cache = cached_data != nullptr;
298298
ScriptCompiler::CompileOptions options =
299299
has_cache ? ScriptCompiler::kConsumeCodeCache
300-
: ScriptCompiler::kEagerCompile;
300+
: ScriptCompiler::kNoCompileOptions;
301301
ScriptCompiler::Source script_source(source, origin, cached_data);
302302

303303
per_process::Debug(DebugCategory::CODE_CACHE,

‎src/node_snapshotable.cc

+1-1
Original file line numberDiff line numberDiff line change
@@ -1484,7 +1484,7 @@ void CompileSerializeMain(const FunctionCallbackInfo<Value>& args) {
14841484
parameters.data(),
14851485
0,
14861486
nullptr,
1487-
ScriptCompiler::kEagerCompile)
1487+
ScriptCompiler::kNoCompileOptions)
14881488
.ToLocal(&fn)) {
14891489
args.GetReturnValue().Set(fn);
14901490
}

0 commit comments

Comments
 (0)