Skip to content

Commit 29f57b7

Browse files
tniessenRafaelGSS
authored andcommittedSep 26, 2022
src: avoid copy when creating Blob
PR-URL: #44616 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
1 parent 5ab3bc9 commit 29f57b7

File tree

2 files changed

+7
-12
lines changed

2 files changed

+7
-12
lines changed
 

‎src/node_blob.cc

+3-5
Original file line numberDiff line numberDiff line change
@@ -71,11 +71,9 @@ bool Blob::HasInstance(Environment* env, v8::Local<v8::Value> object) {
7171
return GetConstructorTemplate(env)->HasInstance(object);
7272
}
7373

74-
BaseObjectPtr<Blob> Blob::Create(
75-
Environment* env,
76-
const std::vector<BlobEntry> store,
77-
size_t length) {
78-
74+
BaseObjectPtr<Blob> Blob::Create(Environment* env,
75+
const std::vector<BlobEntry>& store,
76+
size_t length) {
7977
HandleScope scope(env->isolate());
8078

8179
Local<Function> ctor;

‎src/node_blob.h

+4-7
Original file line numberDiff line numberDiff line change
@@ -45,16 +45,13 @@ class Blob : public BaseObject {
4545
static v8::Local<v8::FunctionTemplate> GetConstructorTemplate(
4646
Environment* env);
4747

48-
static BaseObjectPtr<Blob> Create(
49-
Environment* env,
50-
const std::vector<BlobEntry> store,
51-
size_t length);
48+
static BaseObjectPtr<Blob> Create(Environment* env,
49+
const std::vector<BlobEntry>& store,
50+
size_t length);
5251

5352
static bool HasInstance(Environment* env, v8::Local<v8::Value> object);
5453

55-
const std::vector<BlobEntry> entries() const {
56-
return store_;
57-
}
54+
const std::vector<BlobEntry>& entries() const { return store_; }
5855

5956
void MemoryInfo(MemoryTracker* tracker) const override;
6057
SET_MEMORY_INFO_NAME(Blob)

0 commit comments

Comments
 (0)
Please sign in to comment.