Skip to content

Commit 229e102

Browse files
vmoroztargos
authored andcommittedOct 2, 2024
test: fix embedding test for Windows
PR-URL: #53659 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
1 parent 482302b commit 229e102

File tree

1 file changed

+2
-7
lines changed

1 file changed

+2
-7
lines changed
 

‎test/embedding/test-embedding.js

+2-7
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ const {
1010
} = require('../common/child_process');
1111
const path = require('path');
1212
const fs = require('fs');
13+
const os = require('os');
1314

1415
tmpdir.refresh();
1516
common.allowGlobals(global.require);
@@ -152,12 +153,6 @@ for (const extraSnapshotArgs of [
152153
{ cwd: tmpdir.path });
153154
}
154155

155-
// Skipping rest of the test on Windows because it fails in the CI
156-
// TODO(StefanStojanovic): Reenable rest of the test after fixing it
157-
if (common.isWindows) {
158-
return;
159-
}
160-
161156
// Guarantee NODE_REPL_EXTERNAL_MODULE won't bypass kDisableNodeOptionsEnv
162157
{
163158
spawnSyncAndExit(
@@ -172,6 +167,6 @@ if (common.isWindows) {
172167
{
173168
status: 9,
174169
signal: null,
175-
stderr: `${binary}: NODE_REPL_EXTERNAL_MODULE can't be used with kDisableNodeOptionsEnv\n`,
170+
stderr: `${binary}: NODE_REPL_EXTERNAL_MODULE can't be used with kDisableNodeOptionsEnv${os.EOL}`,
176171
});
177172
}

0 commit comments

Comments
 (0)
Please sign in to comment.