Skip to content

Commit 1e16779

Browse files
targosnodejs-github-bot
authored andcommittedSep 19, 2024
deps: V8: cherry-pick 01a47f3ffff2
Original commit message: [cfi] Add missing 'typename' in SegmentedTable Makes the code more consistent and fixes compilation on older Clang versions. Change-Id: I82abebd500e6651ac5c5b180cd7b49b4f20e8299 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5805956 Reviewed-by: Samuel Groß <saelo@chromium.org> Commit-Queue: Michaël Zasso <mic.besace@gmail.com> Reviewed-by: Stephen Röttger <sroettger@google.com> Cr-Commit-Position: refs/heads/main@{#95809} Refs: v8/v8@01a47f3 PR-URL: #54536 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
1 parent 762a440 commit 1e16779

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed
 

Diff for: ‎common.gypi

+1-1
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636

3737
# Reset this number to 0 on major V8 upgrades.
3838
# Increment by one for each non-official patch applied to deps/v8.
39-
'v8_embedder_string': '-node.7',
39+
'v8_embedder_string': '-node.8',
4040

4141
##### V8 defaults for Node.js #####
4242

Diff for: ‎deps/v8/src/common/segmented-table-inl.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,7 @@ void SegmentedTable<Entry, size>::TearDown() {
103103
}
104104

105105
template <typename Entry, size_t size>
106-
SegmentedTable<Entry, size>::FreelistHead
106+
typename SegmentedTable<Entry, size>::FreelistHead
107107
SegmentedTable<Entry, size>::InitializeFreeList(Segment segment,
108108
uint32_t start_offset) {
109109
DCHECK_LT(start_offset, kEntriesPerSegment);

0 commit comments

Comments
 (0)
Please sign in to comment.