Skip to content

Commit 1d817dc

Browse files
marco-ippolitonodejs-github-bot
authored andcommittedMay 6, 2024
util: move util.isPrimitive to eol
PR-URL: #52744 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent 7224094 commit 1d817dc

File tree

4 files changed

+5
-76
lines changed

4 files changed

+5
-76
lines changed
 

Diff for: ‎doc/api/deprecations.md

+5-4
Original file line numberDiff line numberDiff line change
@@ -1240,6 +1240,9 @@ The `util.isObject()` API has been removed. Please use
12401240

12411241
<!-- YAML
12421242
changes:
1243+
- version: REPLACEME
1244+
pr-url: https://github.com/nodejs/node/pull/52744
1245+
description: End-of-Life deprecation.
12431246
- version: v22.0.0
12441247
pr-url: https://github.com/nodejs/node/pull/50488
12451248
description: Runtime deprecation.
@@ -1255,9 +1258,9 @@ changes:
12551258
description: Documentation-only deprecation.
12561259
-->
12571260

1258-
Type: Runtime
1261+
Type: End-of-Life
12591262

1260-
The [`util.isPrimitive()`][] API is deprecated. Please use
1263+
The `util.isPrimitive()` API has been removed. Please use
12611264
`arg === null || (typeof arg !=='object' && typeof arg !== 'function')`
12621265
instead.
12631266

@@ -3815,8 +3818,6 @@ is deprecated to better align with recommendations per [NIST SP 800-38D][].
38153818
[`util.inspect()`]: util.md#utilinspectobject-options
38163819
[`util.inspect.custom`]: util.md#utilinspectcustom
38173820
[`util.isArray()`]: util.md#utilisarrayobject
3818-
[`util.isPrimitive()`]: util.md#utilisprimitiveobject
3819-
[`util.log()`]: util.md#utillogstring
38203821
[`util.promisify`]: util.md#utilpromisifyoriginal
38213822
[`util.toUSVString()`]: util.md#utiltousvstringstring
38223823
[`util.types`]: util.md#utiltypes

Diff for: ‎doc/api/util.md

-40
Original file line numberDiff line numberDiff line change
@@ -2950,46 +2950,6 @@ util.isArray({});
29502950
// Returns: false
29512951
```
29522952
2953-
### `util.isPrimitive(object)`
2954-
2955-
<!-- YAML
2956-
added: v0.11.5
2957-
deprecated: v4.0.0
2958-
-->
2959-
2960-
> Stability: 0 - Deprecated: Use
2961-
> `(typeof value !== 'object' && typeof value !== 'function') || value === null`
2962-
> instead.
2963-
2964-
* `object` {any}
2965-
* Returns: {boolean}
2966-
2967-
Returns `true` if the given `object` is a primitive type. Otherwise, returns
2968-
`false`.
2969-
2970-
```js
2971-
const util = require('node:util');
2972-
2973-
util.isPrimitive(5);
2974-
// Returns: true
2975-
util.isPrimitive('foo');
2976-
// Returns: true
2977-
util.isPrimitive(false);
2978-
// Returns: true
2979-
util.isPrimitive(null);
2980-
// Returns: true
2981-
util.isPrimitive(undefined);
2982-
// Returns: true
2983-
util.isPrimitive({});
2984-
// Returns: false
2985-
util.isPrimitive(() => {});
2986-
// Returns: false
2987-
util.isPrimitive(/^$/);
2988-
// Returns: false
2989-
util.isPrimitive(new Date());
2990-
// Returns: false
2991-
```
2992-
29932953
### `util.log(string)`
29942954
29952955
<!-- YAML

Diff for: ‎lib/util.js

-15
Original file line numberDiff line numberDiff line change
@@ -89,16 +89,6 @@ function lazyAbortController() {
8989

9090
let internalDeepEqual;
9191

92-
/**
93-
* @deprecated since v4.0.0
94-
* @param {any} arg
95-
* @returns {arg is (boolean | null | number | string | symbol | undefined)}
96-
*/
97-
function isPrimitive(arg) {
98-
return arg === null ||
99-
(typeof arg !== 'object' && typeof arg !== 'function');
100-
}
101-
10292
/**
10393
* @param {number} n
10494
* @returns {string}
@@ -335,11 +325,6 @@ module.exports = {
335325
}
336326
return internalDeepEqual(a, b);
337327
},
338-
isPrimitive: deprecate(isPrimitive,
339-
'The `util.isPrimitive` API is deprecated. ' +
340-
'Please use `arg === null || ' +
341-
'(typeof arg !== "object" && typeof arg !== "function")` instead.',
342-
'DEP0054'),
343328
log: deprecate(log,
344329
'The `util.log API is deprecated. ' +
345330
'Please use console.log() with a custom formatter or a third-party logger instead.',

Diff for: ‎test/parallel/test-util.js

-17
Original file line numberDiff line numberDiff line change
@@ -40,23 +40,6 @@ assert.strictEqual(util.isArray(/regexp/), false);
4040
assert.strictEqual(util.isArray(new Error()), false);
4141
assert.strictEqual(util.isArray({ __proto__: Array.prototype }), false);
4242

43-
// isPrimitive
44-
assert.strictEqual(util.isPrimitive({}), false);
45-
assert.strictEqual(util.isPrimitive(new Error()), false);
46-
assert.strictEqual(util.isPrimitive(new Date()), false);
47-
assert.strictEqual(util.isPrimitive([]), false);
48-
assert.strictEqual(util.isPrimitive(/regexp/), false);
49-
assert.strictEqual(util.isPrimitive(function() {}), false);
50-
assert.strictEqual(util.isPrimitive(new Number(1)), false);
51-
assert.strictEqual(util.isPrimitive(new String('bla')), false);
52-
assert.strictEqual(util.isPrimitive(new Boolean(true)), false);
53-
assert.strictEqual(util.isPrimitive(true), true);
54-
assert.strictEqual(util.isPrimitive(undefined), true);
55-
assert.strictEqual(util.isPrimitive(null), true);
56-
assert.strictEqual(util.isPrimitive(Infinity), true);
57-
assert.strictEqual(util.isPrimitive(NaN), true);
58-
assert.strictEqual(util.isPrimitive(Symbol('symbol')), true);
59-
6043
assert.strictEqual(util.toUSVString('string\ud801'), 'string\ufffd');
6144

6245
{

0 commit comments

Comments
 (0)
Please sign in to comment.