Skip to content

Commit 17a1716

Browse files
targosnodejs-github-bot
authored andcommittedSep 19, 2024
src: update NODE_MODULE_VERSION to 131
Major V8 updates are usually API/ABI incompatible with previous versions. This commit adapts NODE_MODULE_VERSION for V8 12.9. Refs: https://github.com/nodejs/CTC/blob/master/meetings/2016-09-28.md PR-URL: #54536 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
1 parent f68d7d2 commit 17a1716

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed
 

Diff for: ‎doc/abi_version_registry.json

+1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
{
22
"NODE_MODULE_VERSION": [
3+
{ "modules": 131,"runtime": "node", "variant": "v8_12.9", "versions": "23.0.0-pre" },
34
{ "modules": 130,"runtime": "electron", "variant": "electron", "versions": "33" },
45
{ "modules": 129,"runtime": "node", "variant": "v8_12.8", "versions": "23.0.0-pre" },
56
{ "modules": 128,"runtime": "electron", "variant": "electron", "versions": "32" },

Diff for: ‎src/node_version.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@
9595
#if defined(NODE_EMBEDDER_MODULE_VERSION)
9696
#define NODE_MODULE_VERSION NODE_EMBEDDER_MODULE_VERSION
9797
#else
98-
#define NODE_MODULE_VERSION 129
98+
#define NODE_MODULE_VERSION 131
9999
#endif
100100

101101
// The NAPI_VERSION supported by the runtime. This is the inclusive range of

0 commit comments

Comments
 (0)
Please sign in to comment.