Skip to content

Commit 0db38f0

Browse files
authoredApr 15, 2024··
test_runner: expose lcov reporter as newable function
This commit exposes the lcov reporter as a newable function, so that it can be used in the same way as the other reporters. This will allow passing in the options to the reporter as well. This breaks the current behavior of the lcov reporter, which exposes an instance of the reporter. Fixes: #52385 Ref: #49184 PR-URL: #52403 Refs: #49184 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
1 parent f8e325e commit 0db38f0

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed
 

Diff for: ‎lib/test/reporters.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ ObjectDefineProperties(module.exports, {
5050
__proto__: null,
5151
configurable: true,
5252
enumerable: true,
53-
get() {
53+
value: function value() {
5454
lcov ??= require('internal/test_runner/reporter/lcov');
5555
return ReflectConstruct(lcov, arguments);
5656
},

0 commit comments

Comments
 (0)
Please sign in to comment.