Skip to content

Commit 046343e

Browse files
authoredAug 5, 2024··
build: warn for GCC versions earlier than 12.2
Update the warning threshold for GCC to 12.2 starting from Node.js 23. Builds can still proceed with earlier versions of GCC, but are not guaranteed to work. PR-URL: #54081 Refs: nodejs/build#3806 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
1 parent 3616ace commit 046343e

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed
 

Diff for: ‎BUILDING.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -150,7 +150,7 @@ Depending on the host platform, the selection of toolchains may vary.
150150

151151
| Operating System | Compiler Versions |
152152
| ---------------- | -------------------------------------------------------------- |
153-
| Linux | GCC >= 10.1 |
153+
| Linux | GCC >= 12.2 |
154154
| Windows | Visual Studio >= 2022 with the Windows 10 SDK on a 64-bit host |
155155
| macOS | Xcode >= 13 (Apple LLVM >= 12) |
156156

@@ -230,7 +230,7 @@ Consult previous versions of this document for older versions of Node.js:
230230

231231
#### Unix prerequisites
232232

233-
* `gcc` and `g++` >= 10.1 or newer
233+
* `gcc` and `g++` >= 12.2 or newer
234234
* GNU Make 3.81 or newer
235235
* [A supported version of Python][Python versions]
236236
* For test coverage, your Python installation must include pip.

Diff for: ‎configure.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -1178,8 +1178,8 @@ def check_compiler(o):
11781178
print_verbose(f"Detected {'clang ' if is_clang else ''}C++ compiler (CXX={CXX}) version: {version_str}")
11791179
if not ok:
11801180
warn(f'failed to autodetect C++ compiler version (CXX={CXX})')
1181-
elif clang_version < (8, 0, 0) if is_clang else gcc_version < (10, 1, 0):
1182-
warn(f'C++ compiler (CXX={CXX}, {version_str}) too old, need g++ 10.1.0 or clang++ 8.0.0')
1181+
elif clang_version < (8, 0, 0) if is_clang else gcc_version < (12, 2, 0):
1182+
warn(f'C++ compiler (CXX={CXX}, {version_str}) too old, need g++ 12.2.0 or clang++ 8.0.0')
11831183

11841184
ok, is_clang, clang_version, gcc_version = try_check_compiler(CC, 'c')
11851185
version_str = ".".join(map(str, clang_version if is_clang else gcc_version))

0 commit comments

Comments
 (0)
Please sign in to comment.