Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect instruction in cmake.js docs #1632

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

segevfiner
Copy link
Contributor

No description provided.

@legendecas
Copy link
Member

CI failures should be fixed by #1634.

@mhdawson
Copy link
Member

mhdawson commented Feb 7, 2025

@segevfiner could you rebase to the current main branch as it needs a fix that has been landed since you opened it to be able to pass the tests.

Verified

This commit was signed with the committer’s verified signature. The key has expired.
aldas Martti T.
@segevfiner
Copy link
Contributor Author

@segevfiner could you rebase to the current main branch as it needs a fix that has been landed since you opened it to be able to pass the tests.

Rebased.

@legendecas legendecas merged commit 31c4a88 into nodejs:main Feb 10, 2025
53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants