src: enable wrapping Napi namespace with custom namespace #1135
+68
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enable support for a `NAPI_CPP_CUSTOM_NAMESPACE` that would wrap the `Napi` namespace in a custom namespace. This can be helpful when there are multiple parts of a compiled shared library or executable that depend on `node-addon-api`, but different versions of it. In order to avoid symbol conflicts in these cases, namespacing can be used to make sure that the linker would not merge definitions that the compiler potentially generates for the node-addon-api methods.
that seems silly, since I didn’t touch that part, and it’s perfectly valid to do top-level |
When we enabled eslint, it was set up to report on changed files. It has been awkward at times but avoided the need to do a massive change at one time. Can you try adding // eslint-disable-next-linebefore the reported line to see if that quiets the report? |
|
First pass on CI:
|
That doesn’t work because this is a parsing error, not a linting error. I’ve opened #1141, that should avoid this issue in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable support for a
NAPI_CPP_CUSTOM_NAMESPACEthat would wrapthe
Napinamespace in a custom namespace.This can be helpful when there are multiple parts of a compiled
shared library or executable that depend on
node-addon-api,but different versions of it. In order to avoid symbol conflicts
in these cases, namespacing can be used to make sure that the
linker would not merge definitions that the compiler potentially
generates for the node-addon-api methods.