Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Formidable.js refers to errors.pluginFailed but FormidableError.js does not export it #793

Closed
gcatto opened this issue Nov 30, 2021 · 5 comments · Fixed by #794
Closed

Formidable.js refers to errors.pluginFailed but FormidableError.js does not export it #793

gcatto opened this issue Nov 30, 2021 · 5 comments · Fixed by #794

Comments

@gcatto
Copy link

gcatto commented Nov 30, 2021

I am using formidable@3.1.3 and for complicated reasons, I am bundling my web server using webpack. When doing so, it complained that Formidable.js refers to errors.pluginFailed but that FormidableError.js does not export it.

See https://github.com/node-formidable/formidable/blob/master/src/Formidable.js#L409 and https://github.com/node-formidable/formidable/blob/master/src/FormidableError.js#L25

Should it be missingPlugin instead? Or something else?
@GrosSacASac
Copy link
Contributor

Something is missing

@GrosSacASac GrosSacASac mentioned this issue Nov 30, 2021
Merged
@GrosSacASac
Copy link
Contributor

can you try again with the fix-missing-pluginFailed branch ?

@gcatto
Copy link
Author

gcatto commented Nov 30, 2021

@GrosSacASac yeah, that branch does the trick for me. Thanks for the prompt work!

@GrosSacASac
Copy link
Contributor

published 3.1.4

@GrosSacASac
Copy link
Contributor

please help review #791

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: add missing error node-formidable/formidable
2 participants
@gcatto @GrosSacASac