Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use explicit node: imports #786

Merged
merged 2 commits into from Nov 26, 2021
Merged

refactor: use explicit node: imports #786

merged 2 commits into from Nov 26, 2021

Conversation

GrosSacASac
Copy link
Contributor

@GrosSacASac GrosSacASac commented Nov 20, 2021 •
edited

Advantages

  • Distinguish node built-ins from 3rd party packages
  • Increase security in case someone installs a package with the same name as a built-in (it will not be silently be used)
  • Make it easier to port formidable to other platforms (deno) in the future

Added in: Node v14.13.1, v12.20.0

@GrosSacASac GrosSacASac merged commit 1b27107 into master Nov 26, 2021
@GrosSacASac GrosSacASac deleted the refactor-use-explicit-node-imports branch November 26, 2021 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tunnckoCore tunnckoCore Awaiting requested review from tunnckoCore

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@GrosSacASac